HappyGhecko wrote: ↑

Sun Jun 16, 2019 11:54 pm

First (and only post) since 2012. Good job Silverware, you catched a lurker here using only your tidy code.

Shados wrote: ↑

Sun Jun 16, 2019 8:03 pm

Spoiler:      SHOW

Silverware wrote: ↑

Thu Jun 13, 2019 7:26 pm

Just to show how my code looks when being written for a production environment.

Spoiler:      SHOW

Code: Select all

args=""
if [ -n "${MASTER}" ]; then args="${args} -S ${MASTER}"; fi
if [ -n "${CLIENT}" ]; then args="${args} -C ${CLIENT}"; fi
if [ -n "${POLICY}" ]; then args="${args} -k ${POLICY}"; fi
if [ -n "${POLICYTYPE}" ]; then args="${args} -t ${POLICYTYPE}"; fi
if [ -n "${AFTER}" ]; then args="${args} -s ${AFTER}"; fi
if [ -n "${BEFORE}" ]; then args="${args} -e ${BEFORE}"; fi
if [ -n "${NOCLOBBER}" ]; then args="${args} -K"; fi
## Start Restore of File(s)
if [ -z "${FILELIST}" ]; then
	log "Restore Started for ${FILE}"
	${BPRESTORE} ${args} -L ${TMPFILE} -w ${FILE}
	# '-w' is used so that this sciprt will only move on ONCE the file has finished (or failed) restoring
	RET=$?
	log "Restore Finished for ${FILE}"
else
	# Rename only works as a filelist, so we include the feature here
	if [ -n "${RENAME}" ]; then args="${args} -R ${RENAME}"; fi
	log "Restore Started for Multiple Files"
	${BPRESTORE} ${args} -L ${TMPFILE} -w -f ${FILELIST}
	# '-w' is used so that this sciprt will only move on ONCE the file has finished (or failed) restoring
	RET=$?
	log "Restore Finished for Multiple Files"
fi

So that you can see the difference.

Pretty reasonable. Assuming it's being run on a vaguely-recent bash, I would suggest some changes:

• Construct `args` by appending to an indexed array, not a string, like:

  Code: Select all

  args = (); args+=("-S" "${MASTER}")

• Then, when calling `BPRESTORE`, expand `args` as an array to ensure each item is passed as a separate arg, like:

  Code: Select all

  ${BPRESTORE} "${args[@]}" ... 

• Double-quote the other arguments you pass to `BPRESTORE`; even if you know a priori that they do not contain spaces or globs, that may no longer be true after you or someone else edits the script later, so you're still better off quoting them to prevent possible unexpected behaviour in the future.
• The combination of those three changes clarifies the intent of the code, and prevents unexpected word-splitting changing what should be a single argument token into multiple tokens.
• Start using shellcheck. Ideally, with editor integration.

The quotes around the ${BPRESTORE} line are actually EXPLICITLY left out, because for some reason the application decides that the quotes means that that's actually a file and not a set of arguments

Employee 2-4601 wrote: ↑

Mon Jun 17, 2019 4:31 am

I definitely agree with the practice of quoting enthusiastically in shell scripts, even when it's not strictly necessary. My theory is always that accidentally using too much quoting will cause immediate problems which are easy to debug (removing the quotes, when necessary); whereas not enough quoting may very well work fine on your development data, and only break later (maybe much later), in ways which may be difficult to debug. Ditto with using curly braces around variable names even when not actually needed.

The quotes around the ${BPRESTORE} line are actually EXPLICITLY left out, because for some reason the application decides that the quotes means that that's actually a file and not a set of arguments

Yes, quoting a single variable "${args}" makes the whole thing a single argument; but IIRC bash arrays work like the standard $@ in which case quoting "${args[@]}" would be equivalent to having individually quoted each element of the array, just like "$@" does for the positional parameters.

(I'd be more certain of that, but I have a masochistic habit of trying to write all my shell scripts as portable /bin/sh scripts even when I don't need to, so I almost never use bash features...)

sargs="a b c d"
aargs=( "a b" c d )

ls "$sargs"		# lists the single file "a b c d"
ls $sargs		# lists 4 files "a", "b", "c", "d"
ls "${aargs[@]}"	# lists 3 files: "a b", "c", "d"

ls ${aargs[@]}		# lists 4 files: "a", "b", "c", "d"
ls ${aargs[*]}		# lists 4 files: "a", "b", "c", "d"
ls "${aargs[*]}"	# lists 1 file "a b c d"

Victor Tombs wrote: ↑

Fri Jun 07, 2019 2:22 am

Tycow wrote: ↑

Thu May 02, 2019 7:30 pm

Yea, I'd be interested in getting a copy of the soundtrack as a consolation prize!

Maybe Josh intends using the soundtrack in some other, as yet, unannounced project, Tycow.

Pure speculation on my part.

Tycow wrote: ↑

Fri Jun 21, 2019 3:29 am

Maybe, but given his track record I'd still like a copy of the sound track as a separate thing...

Victor Tombs wrote: ↑

Sat Jun 22, 2019 12:55 pm

Tycow wrote: ↑

Fri Jun 21, 2019 3:29 am

Maybe, but given his track record I'd still like a copy of the sound track as a separate thing...

I wouldn't argue with that, Tycow. There isn't much Josh can offer in a complete form but the soundtrack was delivered in full by François. I'd like the CD's but I'd settle for a quality download.

ResultsMayDiffer wrote: ↑

Mon Jun 24, 2019 5:33 am

Hey Josh. Do me a favor and release the source code. Nobody is going to make a huge profit off your work you worry too much.

cuisinart8 wrote: ↑

Mon Jun 24, 2019 11:22 am

ResultsMayDiffer wrote: ↑

Mon Jun 24, 2019 5:33 am

Hey Josh. Do me a favor and release the source code. Nobody is going to make a huge profit off your work you worry too much.

He's translating it all from spaghetti code into something that people not named Josh Parnell can mess with. Releasing the source code is completely pointless if it's too much of a mess for people to do anything with it. We were waiting years for LT, we can wait a bit longer for the source.

CSE wrote: ↑

Mon Jun 24, 2019 12:23 pm

*snip*

cuisinart8 wrote: ↑

Mon Jun 24, 2019 11:22 am

He's translating it all from spaghetti code into something that people not named Josh Parnell can mess with. Releasing the source code is completely pointless if it's too much of a mess for people to do anything with it. We were waiting years for LT, we can wait a bit longer for the source.